Update Url::domain docs to show that it includes subdomain
#1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: supercoolspy <66487448+supercoolspy@users.noreply.github.com>
Manishearth
approved these changes
Jul 19, 2025
|
Thanks!! |
|
Clippy failures are unrelated and can be ignored (though if you want to fix them in a separate PR that would be welcome!) MSRV tests need to be fixed. Hm. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1057 +/- ##
=======================================
Coverage ? 82.33%
=======================================
Files ? 24
Lines ? 4245
Branches ? 0
=======================================
Hits ? 3495
Misses ? 750
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Do you think it would be good to add this to the host methods also since they have the same functionality? |
|
Sure, I guess. |
Signed-off-by: supercoolspy <66487448+supercoolspy@users.noreply.github.com>
|
I can't merge this until someone approves my other PR (which fixes CI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got confused by this, and I think it could be a helpful docs addition for users to understand